Follow-ups from the first review #2

Closed
opened 2026-11-15 09:04:23 +00:00 by squid · 0 comments
Owner

Minor findings of the first review of the generator. None blocks the first release.

  • An empty value passes Require: Title: or ID: alone is accepted, and an empty title gives an empty <title>.
  • Heading ids: an explicit {#foo} can repeat another id, suffixes can clash (a, a-2, a-2), a heading with no ASCII letters or digits gets an empty id, and the contents list puts the id in href unescaped.
  • Placeholders are replaced inside code spans and fenced blocks, and there is no way to write a literal {{name}}.
  • A failed write leaves a half-written output folder, and files of earlier builds stay (the deploy builds into a fresh folder, which hides both).
  • The em dash rule does not check Title, Description and Note of manifesto pages, its error counts lines from the start of the body, and &mdash; entities pass.
  • Feed: base_url is not required, src="/ links are not made absolute, and a news page that is not a folder index puts the feed at /news.htmlfeed.xml.
  • Small: a category repeated in one post is counted twice, a literal {{latest_news}} in a title gives a false error, extra positional arguments to motorino build are ignored, and one comment above markdownLink is headed with a name that does not exist.
Minor findings of the first review of the generator. None blocks the first release. - An empty value passes `Require`: `Title:` or `ID:` alone is accepted, and an empty title gives an empty `<title>`. - Heading ids: an explicit `{#foo}` can repeat another id, suffixes can clash (`a`, `a-2`, `a-2`), a heading with no ASCII letters or digits gets an empty id, and the contents list puts the id in `href` unescaped. - Placeholders are replaced inside code spans and fenced blocks, and there is no way to write a literal `{{name}}`. - A failed write leaves a half-written output folder, and files of earlier builds stay (the deploy builds into a fresh folder, which hides both). - The em dash rule does not check `Title`, `Description` and `Note` of manifesto pages, its error counts lines from the start of the body, and `&mdash;` entities pass. - Feed: `base_url` is not required, `src="/` links are not made absolute, and a news page that is not a folder index puts the feed at `/news.htmlfeed.xml`. - Small: a category repeated in one post is counted twice, a literal `{{latest_news}}` in a title gives a false error, extra positional arguments to `motorino build` are ignored, and one comment above `markdownLink` is headed with a name that does not exist.
squid closed this issue 2026-11-15 09:40:06 +00:00
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
squid/motorino#2
No description provided.