From 097314e8d93e7f4cdc40a5d75cd7fe2072564fea Mon Sep 17 00:00:00 2001 From: tgiachi Date: Tue, 10 Nov 2026 15:16:02 +0100 Subject: [PATCH] test(web): check publicDomain directly mail.ParseAddress already refuses empty labels such as x..com, so the form-level tests could not see the empty-label check in publicDomain. A direct table test pins the rule on its own. --- internal/web/web_test.go | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/internal/web/web_test.go b/internal/web/web_test.go index edc8438..915f9d3 100644 --- a/internal/web/web_test.go +++ b/internal/web/web_test.go @@ -875,3 +875,16 @@ func TestSubscribeLimiterIsCapped(t *testing.T) { t.Fatalf("size = %d, want 2", l.size()) } } + +// mail.ParseAddress already refuses most of these; publicDomain must not depend on it. +func TestPublicDomain(t *testing.T) { + for d, want := range map[string]bool{ + "example.com": true, "members.test": true, "a-b.example": true, "X1.Example.ORG": true, + "x..com": false, ".x.com": false, "x.com.": false, "x": false, "localhost": false, "[127.0.0.1]": false, + "a.localhost": false, "a.local": false, "a.internal": false, "a.invalid": false, "x_y.com": false, + } { + if got := publicDomain(d); got != want { + t.Errorf("publicDomain(%q) = %v, want %v", d, got, want) + } + } +}