- router: an approved post is remembered, so the MTA's copy is refused - store: a post with no recipients stores no message body - app: an API request in flight during Close gets its answer - app: finished LMTP sessions leave the connection tracker - router: drop a TrimSpace on the Message-ID that net/mail already does
126 lines
3.5 KiB
Go
126 lines
3.5 KiB
Go
package router
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
)
|
|
|
|
func pending(t *testing.T, e *env) int {
|
|
t.Helper()
|
|
st, err := e.s.OutboxStats()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
return st.Pending
|
|
}
|
|
|
|
func (e *env) post(t *testing.T, msg string) error {
|
|
t.Helper()
|
|
res, err := e.r.Route("alice@example.com", "dev@example.org", []byte(msg))
|
|
if err != nil {
|
|
t.Fatalf("route: %v", err)
|
|
}
|
|
return e.r.Deliver(res)
|
|
}
|
|
|
|
func TestTheSamePostIsDeliveredOnce(t *testing.T) {
|
|
e := newEnv(t)
|
|
woke := 0
|
|
e.r.OnEnqueue = func() { woke++ }
|
|
msg := "From: alice@example.com\r\nSubject: hi\r\nMessage-ID: <one@x>\r\n\r\nbody\r\n"
|
|
if err := e.post(t, msg); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := e.post(t, msg); !errors.Is(err, ErrDuplicate) {
|
|
t.Fatalf("want ErrDuplicate, got %v", err)
|
|
}
|
|
if n := pending(t, e); n != 2 {
|
|
t.Fatalf("pending = %d, want one delivery per member", n)
|
|
}
|
|
if woke != 1 {
|
|
t.Fatalf("OnEnqueue called %d times for a duplicate", woke)
|
|
}
|
|
}
|
|
|
|
func TestAnotherMessageIDIsAnotherPost(t *testing.T) {
|
|
e := newEnv(t)
|
|
if err := e.post(t, "From: alice@example.com\r\nMessage-ID: <one@x>\r\n\r\nbody\r\n"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := e.post(t, "From: alice@example.com\r\nMessage-ID: <two@x>\r\n\r\nbody\r\n"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if n := pending(t, e); n != 4 {
|
|
t.Fatalf("pending = %d", n)
|
|
}
|
|
}
|
|
|
|
func TestAPostWithoutMessageIDIsKnownByItsContent(t *testing.T) {
|
|
e := newEnv(t)
|
|
msg := "From: alice@example.com\r\nSubject: hi\r\n\r\nbody\r\n"
|
|
if err := e.post(t, msg); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := e.post(t, msg); !errors.Is(err, ErrDuplicate) {
|
|
t.Fatalf("the same bytes again: want ErrDuplicate, got %v", err)
|
|
}
|
|
if err := e.post(t, msg+"more\r\n"); err != nil {
|
|
t.Fatalf("another body is another post: %v", err)
|
|
}
|
|
if n := pending(t, e); n != 4 {
|
|
t.Fatalf("pending = %d", n)
|
|
}
|
|
}
|
|
|
|
func TestPostIDIgnoresTheRestWhenThereIsAMessageID(t *testing.T) {
|
|
a := postID([]byte("Message-ID: <one@x> \r\nSubject: a\r\n\r\nx"))
|
|
b := postID([]byte("Subject: b\r\nMessage-ID: <one@x>\r\n\r\ny"))
|
|
if a != b || a != "mid:<one@x>" {
|
|
t.Fatalf("%q %q", a, b)
|
|
}
|
|
if c := postID([]byte("Subject: b\r\n\r\ny")); c == postID([]byte("Subject: b\r\n\r\nz")) || len(c) < 10 {
|
|
t.Fatalf("content hash: %q", c)
|
|
}
|
|
if postID([]byte("Message-ID: <one@x>\r\n\r\n")) == postID([]byte("Message-ID: <One@x>\r\n\r\n")) {
|
|
t.Fatal("Message-IDs are case sensitive")
|
|
}
|
|
}
|
|
|
|
func TestAnApprovedPostIsDeliveredEvenIfItWasSeen(t *testing.T) {
|
|
e := newEnv(t)
|
|
msg := "From: alice@example.com\r\nSubject: hi\r\nMessage-ID: <one@x>\r\n\r\nbody\r\n"
|
|
if err := e.post(t, msg); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
id, err := e.s.HoldMessage(e.list.ID, "alice@example.com", []byte(msg), "r")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := e.r.Release(id); err != nil {
|
|
t.Fatalf("release: %v", err)
|
|
}
|
|
if n := pending(t, e); n != 4 {
|
|
t.Fatalf("pending = %d, the approval must deliver", n)
|
|
}
|
|
if err := e.post(t, msg); !errors.Is(err, ErrDuplicate) {
|
|
t.Fatalf("a copy after the approval: want ErrDuplicate, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestAnApprovedPostIsRemembered(t *testing.T) {
|
|
e := newEnv(t)
|
|
msg := "From: alice@example.com\r\nSubject: hi\r\nMessage-ID: <held@x>\r\n\r\nbody\r\n"
|
|
id, err := e.s.HoldMessage(e.list.ID, "alice@example.com", []byte(msg), "r")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := e.r.Release(id); err != nil {
|
|
t.Fatalf("release: %v", err)
|
|
}
|
|
if err := e.post(t, msg); !errors.Is(err, ErrDuplicate) {
|
|
t.Fatalf("the MTA's copy of an approved post: want ErrDuplicate, got %v", err)
|
|
}
|
|
if n := pending(t, e); n != 2 {
|
|
t.Fatalf("pending = %d", n)
|
|
}
|
|
}
|