- Rename the Go module from codeberg.org/squidd/parsimony to git.kmalloc.org/squid/parsimony in go.mod and every import. - Fix .gitignore: the bare `parsimony` pattern also ignored the cmd/parsimony folder, so the main package was never committed and a clean checkout could not be built. Anchor it to the root (`/parsimony`) and add cmd/parsimony.
158 lines
4.6 KiB
Go
158 lines
4.6 KiB
Go
package router
|
|
|
|
import (
|
|
"bytes"
|
|
"errors"
|
|
"mime"
|
|
"net/mail"
|
|
"strings"
|
|
"testing"
|
|
|
|
"git.kmalloc.org/squid/parsimony/internal/store"
|
|
)
|
|
|
|
func setup(t *testing.T) *Router {
|
|
t.Helper()
|
|
s, err := store.Open(":memory:")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
t.Cleanup(func() { s.Close() })
|
|
l, _ := s.CreateList("dev", "example.org", "Dev")
|
|
s.AddMember(l.ID, "alice@example.com", "Alice")
|
|
s.AddMember(l.ID, "bob@example.com", "Bob")
|
|
return New(s)
|
|
}
|
|
|
|
func TestRouteMemberPost(t *testing.T) {
|
|
r := setup(t)
|
|
res, err := r.Route("alice@example.com", "dev@example.org", []byte("From: alice@example.com\r\nSubject: hi\r\n\r\nbody\r\n"))
|
|
if err != nil {
|
|
t.Fatalf("route: %v", err)
|
|
}
|
|
if res.List.Name != "dev" {
|
|
t.Fatalf("list: %+v", res.List)
|
|
}
|
|
if len(res.Recipients) != 2 {
|
|
t.Fatalf("want 2 recipients, got %v", res.Recipients)
|
|
}
|
|
}
|
|
|
|
func TestRouteSenderCaseInsensitive(t *testing.T) {
|
|
r := setup(t)
|
|
if _, err := r.Route("ALICE@Example.com", "dev@example.org", []byte("From: Alice <alice@example.com>\r\n\r\nx\r\n")); err != nil {
|
|
t.Fatalf("route: %v", err)
|
|
}
|
|
}
|
|
|
|
func TestRouteNonMemberRejected(t *testing.T) {
|
|
r := setup(t)
|
|
_, err := r.Route("mallory@evil.com", "dev@example.org", nil)
|
|
if !errors.Is(err, ErrNotMember) {
|
|
t.Fatalf("want ErrNotMember, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestRouteUnknownList(t *testing.T) {
|
|
r := setup(t)
|
|
_, err := r.Route("alice@example.com", "nope@example.org", nil)
|
|
if !errors.Is(err, ErrUnknownList) {
|
|
t.Fatalf("want ErrUnknownList, got %v", err)
|
|
}
|
|
}
|
|
|
|
func header(t *testing.T, data []byte) mail.Header {
|
|
t.Helper()
|
|
m, err := mail.ReadMessage(bytes.NewReader(data))
|
|
if err != nil {
|
|
t.Fatalf("parse: %v", err)
|
|
}
|
|
return m.Header
|
|
}
|
|
|
|
const sample = "From: Alice <alice@example.com>\r\nTo: dev@example.org\r\nSubject: hi\r\nList-Id: <spoof.example>\r\n\r\nbody line\r\n"
|
|
|
|
func TestRewriteHeaders(t *testing.T) {
|
|
r := setup(t)
|
|
r.BaseURL = "https://lists.example.org"
|
|
res, err := r.Route("alice@example.com", "dev@example.org", []byte(sample))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
h := header(t, res.Data)
|
|
if got := h.Get("List-Id"); got != "Dev <dev.example.org>" {
|
|
t.Errorf("List-Id = %q", got)
|
|
}
|
|
if got := h.Get("List-Post"); got != "<mailto:dev@example.org>" {
|
|
t.Errorf("List-Post = %q", got)
|
|
}
|
|
if got := h.Get("From"); got != `"Alice via Dev" <dev@example.org>` {
|
|
t.Errorf("From = %q", got)
|
|
}
|
|
if got := h.Get("Reply-To"); got != "Alice <alice@example.com>" {
|
|
t.Errorf("Reply-To = %q", got)
|
|
}
|
|
if !strings.HasSuffix(string(res.Data), "\r\n\r\nbody line\r\n") {
|
|
t.Errorf("body altered: %q", res.Data)
|
|
}
|
|
if n := len(h["List-Id"]); n != 1 {
|
|
t.Errorf("want a single List-Id, got %d", n)
|
|
}
|
|
}
|
|
|
|
func TestRewriteKeepsExistingReplyTo(t *testing.T) {
|
|
r := setup(t)
|
|
msg := "From: Alice <alice@example.com>\r\nReply-To: team@example.com\r\n\r\nx\r\n"
|
|
res, _ := r.Route("alice@example.com", "dev@example.org", []byte(msg))
|
|
if got := header(t, res.Data).Get("Reply-To"); got != "team@example.com" {
|
|
t.Errorf("Reply-To = %q", got)
|
|
}
|
|
}
|
|
|
|
func TestListIdWithANonASCIITitleIsEncoded(t *testing.T) {
|
|
l := store.List{Name: "dev", Domain: "example.org", Title: "Développeurs ☕ \"café\""}
|
|
out, err := rewrite(l, []byte(sample))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
for _, line := range strings.Split(string(out), "\r\n") {
|
|
if strings.HasPrefix(line, "List-Id:") {
|
|
for _, b := range []byte(line) {
|
|
if b >= 0x80 {
|
|
t.Fatalf("raw non-ASCII in %q", line)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
m, err := mail.ReadMessage(bytes.NewReader(out))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
raw := m.Header.Get("List-Id")
|
|
if !strings.HasSuffix(raw, " <dev.example.org>") {
|
|
t.Fatalf("the id must stay a plain <id>: %q", raw)
|
|
}
|
|
phrase, err := new(mime.WordDecoder).DecodeHeader(strings.TrimSuffix(raw, " <dev.example.org>"))
|
|
if err != nil || phrase != l.Title {
|
|
t.Fatalf("phrase = %q (%v), want %q", phrase, err, l.Title)
|
|
}
|
|
// A long title is folded into several encoded words and still reads back.
|
|
long := store.List{Name: "dev", Domain: "example.org", Title: strings.Repeat("è", 200)}
|
|
out, err = rewrite(long, []byte(sample))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
m, err = mail.ReadMessage(bytes.NewReader(out))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
raw = m.Header.Get("List-Id")
|
|
if phrase, err := new(mime.WordDecoder).DecodeHeader(strings.TrimSuffix(raw, " <dev.example.org>")); err != nil || phrase != long.Title {
|
|
t.Fatalf("long phrase = %q (%v)", phrase, err)
|
|
}
|
|
// An ASCII title is left as it is.
|
|
out, _ = rewrite(store.List{Name: "dev", Domain: "example.org", Title: "Dev"}, []byte(sample))
|
|
if !strings.Contains(string(out), "List-Id: Dev <dev.example.org>\r\n") {
|
|
t.Fatalf("ascii title changed: %q", out)
|
|
}
|
|
}
|