parsimony/internal/store/store_test.go
tgiachi d43c47ea08 fix(store): put the pragmas in the DSN so every connection has them
- foreign_keys, busy_timeout(5000) and WAL now come from the DSN, not from
  an Exec on one connection
- test: every connection of a 2-connection pool, in memory and on disk
2026-11-10 11:49:00 +01:00

168 lines
4.4 KiB
Go

package store
import (
"context"
"database/sql"
"errors"
"path/filepath"
"testing"
)
func newTestStore(t *testing.T) *Store {
t.Helper()
s, err := Open(":memory:")
if err != nil {
t.Fatalf("open: %v", err)
}
t.Cleanup(func() { s.Close() })
return s
}
func TestCreateAndFindList(t *testing.T) {
s := newTestStore(t)
if _, err := s.CreateList("dev", "example.org", "Dev list"); err != nil {
t.Fatalf("create: %v", err)
}
l, err := s.FindList("dev@example.org")
if err != nil {
t.Fatalf("find: %v", err)
}
if l.Name != "dev" || l.Domain != "example.org" || l.Title != "Dev list" {
t.Fatalf("unexpected list: %+v", l)
}
}
func TestFindListUnknown(t *testing.T) {
s := newTestStore(t)
if _, err := s.FindList("nope@example.org"); !errors.Is(err, ErrNotFound) {
t.Fatalf("want ErrNotFound, got %v", err)
}
}
func TestFindListCaseInsensitive(t *testing.T) {
s := newTestStore(t)
s.CreateList("dev", "example.org", "Dev")
if _, err := s.FindList("DEV@Example.ORG"); err != nil {
t.Fatalf("find: %v", err)
}
}
func TestMembers(t *testing.T) {
s := newTestStore(t)
l, _ := s.CreateList("dev", "example.org", "Dev")
if err := s.AddMember(l.ID, "Alice@Example.com", "Alice"); err != nil {
t.Fatalf("add: %v", err)
}
ok, err := s.IsMember(l.ID, "alice@example.com")
if err != nil || !ok {
t.Fatalf("want member, got %v %v", ok, err)
}
ok, _ = s.IsMember(l.ID, "bob@example.com")
if ok {
t.Fatal("bob should not be a member")
}
ms, err := s.Members(l.ID)
if err != nil || len(ms) != 1 || ms[0].Address != "alice@example.com" {
t.Fatalf("members: %+v %v", ms, err)
}
}
func TestListLifecycle(t *testing.T) {
s := newTestStore(t)
a, _ := s.CreateList("a", "example.org", "A")
s.CreateList("b", "example.org", "B")
ls, err := s.ListLists()
if err != nil || len(ls) != 2 {
t.Fatalf("lists: %+v %v", ls, err)
}
got, err := s.GetList(a.ID)
if err != nil || got.Name != "a" {
t.Fatalf("get: %+v %v", got, err)
}
if _, err := s.GetList(999); !errors.Is(err, ErrNotFound) {
t.Fatalf("want ErrNotFound, got %v", err)
}
if err := s.UpdateList(a.ID, "New title"); err != nil {
t.Fatal(err)
}
got, _ = s.GetList(a.ID)
if got.Title != "New title" {
t.Fatalf("title = %q", got.Title)
}
if err := s.UpdateList(999, "x"); !errors.Is(err, ErrNotFound) {
t.Fatalf("want ErrNotFound, got %v", err)
}
s.AddMember(a.ID, "x@y.com", "")
if err := s.DeleteList(a.ID); err != nil {
t.Fatal(err)
}
if _, err := s.GetList(a.ID); !errors.Is(err, ErrNotFound) {
t.Fatal("list should be gone")
}
if err := s.DeleteList(a.ID); !errors.Is(err, ErrNotFound) {
t.Fatalf("want ErrNotFound, got %v", err)
}
}
func TestDuplicateList(t *testing.T) {
s := newTestStore(t)
s.CreateList("a", "example.org", "A")
if _, err := s.CreateList("A", "Example.org", "again"); !errors.Is(err, ErrExists) {
t.Fatalf("want ErrExists, got %v", err)
}
}
func TestRemoveMember(t *testing.T) {
s := newTestStore(t)
l, _ := s.CreateList("a", "example.org", "A")
s.AddMember(l.ID, "x@y.com", "")
if err := s.RemoveMember(l.ID, "X@y.com"); err != nil {
t.Fatal(err)
}
if ok, _ := s.IsMember(l.ID, "x@y.com"); ok {
t.Fatal("still a member")
}
if err := s.RemoveMember(l.ID, "x@y.com"); !errors.Is(err, ErrNotFound) {
t.Fatalf("want ErrNotFound, got %v", err)
}
}
// Every connection of the pool must enforce foreign keys and wait on a busy
// database, not only the first one: the pragmas live in the DSN.
func TestEveryConnectionHasThePragmas(t *testing.T) {
for _, path := range []string{":memory:", filepath.Join(t.TempDir(), "p.db")} {
s, err := Open(path)
if err != nil {
t.Fatalf("open %s: %v", path, err)
}
s.db.SetMaxOpenConns(2)
ctx := context.Background()
c1, err := s.db.Conn(ctx)
if err != nil {
t.Fatal(err)
}
c2, err := s.db.Conn(ctx)
if err != nil {
t.Fatal(err)
}
for i, c := range []*sql.Conn{c1, c2} {
var fk, busy int
if err := c.QueryRowContext(ctx, "PRAGMA foreign_keys").Scan(&fk); err != nil || fk != 1 {
t.Errorf("%s conn %d: foreign_keys = %d, %v", path, i, fk, err)
}
if err := c.QueryRowContext(ctx, "PRAGMA busy_timeout").Scan(&busy); err != nil || busy != 5000 {
t.Errorf("%s conn %d: busy_timeout = %d, %v", path, i, busy, err)
}
if path != ":memory:" {
var mode string
if err := c.QueryRowContext(ctx, "PRAGMA journal_mode").Scan(&mode); err != nil || mode != "wal" {
t.Errorf("%s conn %d: journal_mode = %q, %v", path, i, mode, err)
}
}
}
c1.Close()
c2.Close()
s.Close()
}
}