parsimony/internal/store/publisher_test.go
tgiachi 5bed75864f feat(store): publisher flag on members and the publishers post policy
- members.publisher column, added to old databases by an additive migration
- Member.Publisher, SetPublisher (ErrNotFound for a non-member) and IsPublisher
- a publisher disabled by bounces is still a publisher
- AddMember keeps the publisher flag of an existing member
- SetPolicies accepts the publishers post policy
2026-11-10 12:35:58 +01:00

126 lines
3.6 KiB
Go

package store
import (
"errors"
"testing"
)
func TestANewMemberIsNotAPublisher(t *testing.T) {
s := newTestStore(t)
l, _ := s.CreateList("news", "example.org", "News")
s.AddMember(l.ID, "a@x.com", "")
ms, _ := s.Members(l.ID)
if len(ms) != 1 || ms[0].Publisher {
t.Fatalf("members: %+v", ms)
}
if ok, err := s.IsPublisher(l.ID, "a@x.com"); ok || err != nil {
t.Fatalf("IsPublisher: %v %v", ok, err)
}
}
func TestSetPublisherPromotesAndDemotes(t *testing.T) {
s := newTestStore(t)
l, _ := s.CreateList("news", "example.org", "News")
s.AddMember(l.ID, "a@x.com", "")
s.AddMember(l.ID, "b@x.com", "")
if err := s.SetPublisher(l.ID, "A@X.com", true); err != nil {
t.Fatal(err)
}
if ok, err := s.IsPublisher(l.ID, "a@X.COM"); !ok || err != nil {
t.Fatalf("promoted: %v %v", ok, err)
}
if ok, _ := s.IsPublisher(l.ID, "b@x.com"); ok {
t.Fatal("only a is a publisher")
}
ms, _ := s.Members(l.ID)
if !ms[0].Publisher || ms[1].Publisher {
t.Fatalf("members: %+v", ms)
}
if m, _ := s.MemberByID(ms[0].ID); !m.Publisher {
t.Fatalf("by id: %+v", m)
}
if err := s.SetPublisher(l.ID, "a@x.com", false); err != nil {
t.Fatal(err)
}
if ok, _ := s.IsPublisher(l.ID, "a@x.com"); ok {
t.Fatal("demoted")
}
}
func TestSetPublisherOfANonMemberIsNotFound(t *testing.T) {
s := newTestStore(t)
l, _ := s.CreateList("news", "example.org", "News")
other, _ := s.CreateList("dev", "example.org", "Dev")
s.AddMember(other.ID, "a@x.com", "")
if err := s.SetPublisher(l.ID, "a@x.com", true); !errors.Is(err, ErrNotFound) {
t.Fatalf("want ErrNotFound, got %v", err)
}
if ok, _ := s.IsPublisher(other.ID, "a@x.com"); ok {
t.Fatal("the flag is per list")
}
}
func TestAPublisherDisabledByBouncesIsStillAPublisher(t *testing.T) {
s := newTestStore(t)
l, _ := s.CreateList("news", "example.org", "News")
s.AddMember(l.ID, "a@x.com", "")
s.SetPublisher(l.ID, "a@x.com", true)
ms, _ := s.Members(l.ID)
for i := 0; i < BounceThreshold; i++ {
s.RecordHardBounce(ms[0].ID, BounceThreshold)
}
if m, _ := s.MemberByID(ms[0].ID); !m.Disabled {
t.Fatal("setup: the member is disabled")
}
if ok, err := s.IsPublisher(l.ID, "a@x.com"); !ok || err != nil {
t.Fatalf("still a publisher: %v %v", ok, err)
}
}
func TestReAddingAMemberKeepsThePublisherFlag(t *testing.T) {
s := newTestStore(t)
l, _ := s.CreateList("news", "example.org", "News")
s.AddMember(l.ID, "a@x.com", "")
s.SetPublisher(l.ID, "a@x.com", true)
if err := s.AddMember(l.ID, "a@x.com", "Alice"); err != nil {
t.Fatal(err)
}
ms, _ := s.Members(l.ID)
if len(ms) != 1 || !ms[0].Publisher || ms[0].DisplayName != "Alice" {
t.Fatalf("members: %+v", ms)
}
}
func TestPublishersIsAPostPolicy(t *testing.T) {
s := newTestStore(t)
l, _ := s.CreateList("news", "example.org", "News")
if err := s.SetPolicies(l.ID, PostPublishers, JoinOpen, ArchivePublic); err != nil {
t.Fatal(err)
}
if got, _ := s.GetList(l.ID); got.PostPolicy != "publishers" {
t.Fatalf("policy: %+v", got)
}
}
func TestMigrationAddsThePublisherColumn(t *testing.T) {
path := t.TempDir() + "/old.db"
s, _ := Open(path)
l, _ := s.CreateList("news", "example.org", "News")
s.AddMember(l.ID, "a@x.com", "A")
if _, err := s.db.Exec(`ALTER TABLE members DROP COLUMN publisher`); err != nil {
t.Fatal(err)
}
s.Close()
s2, err := Open(path)
if err != nil {
t.Fatalf("migrate: %v", err)
}
defer s2.Close()
ms, err := s2.Members(l.ID)
if err != nil || len(ms) != 1 || ms[0].Address != "a@x.com" || ms[0].Publisher {
t.Fatalf("an old member survives and is not a publisher: %+v %v", ms, err)
}
if err := s2.SetPublisher(l.ID, "a@x.com", true); err != nil {
t.Fatal(err)
}
}