fix(discovery): ids from files, adoption and the scanner lock
- fix: a discovered artist adopted by id under another spelling kept its old
match key, so the next file with the new spelling and no id created a second
artist. The key now follows the name
- fix: when a real artist without an id and a discovered artist holding the id
have the same name, the id now goes to the real artist and the discovered one
lets go of it. Before, the scan created a second real artist and a second
album, and could not repair it because the id was taken
- fix: when a file without an id adopts a discovered artist that had a provider
id, the tags, the fetch records and the similar artists read under that id
are dropped, since they are not known to be about the user's artist. Links
from other artists to it stay. A file that confirms the very same id keeps
everything
- fix: the album artist id is only read when the file has an album artist tag;
with the tag missing the name is a fallback and the id would have landed on the
wrong artist (a Various Artists id on the track's own artist)
- fix: one artist credit with one id ("X feat. Y" with the id of X, how beets
writes it) is not paired: no id is safer than a wrong one. A name that is
itself a single letter or contains a slash still gets its id
- fix: on PostgreSQL the scanner took the artist lock after it had already
changed artist rows, which could deadlock with a concurrent similar-artists
save. SaveFile now takes the lock first, once
- fix: Last.fm does not know every MusicBrainz id: when it does not know the id
and there is a name, the name is tried, never autocorrected, as before ids
were read from files
- fix: waiting for one provider's tags is bounded at 20 seconds, so a rate
limited provider cannot hold a page for a minute
- docs: the tag range is 1 to 100 (a tag with no votes is dropped), the spec says
where an artist's id can come from, and the README says when Last.fm gets an id
- test: adoption by spelling, the real artist with a discovered namesake,
dropping and keeping what was read, album artist fallback, credits, an ID3
frame, and the id-then-name fallback of Last.fm
This commit is contained in:
parent
07ea997cd0
commit
175b87a4cc
1 changed files with 407 additions and 99 deletions
|
|
@ -608,15 +608,16 @@ paths:
|
|||
What each provider says kind of music this artist plays: Last.fm's top tags and
|
||||
MusicBrainz's tags and genres. There is always one entry for each, Last.fm first. The
|
||||
weights are the providers' own numbers, kept as they came and never mixed: Last.fm's is
|
||||
relative to the artist (0 to 100, the top tag is usually 100), MusicBrainz's is a count of
|
||||
votes. `genre` is true for a MusicBrainz tag that it also lists among its curated genres.
|
||||
relative to the artist (1 to 100, the top tag is usually 100; a tag with no votes is dropped),
|
||||
MusicBrainz's is a count of votes. `genre` is true for a MusicBrainz tag that it also lists among its curated genres.
|
||||
|
||||
A provider is only asked when an admin switched it on and its stored answer is missing or
|
||||
old (7 days; a "no such artist" answer is kept 1 day), with the same rules as
|
||||
`GET /artists/{id}/similar`. What is sent is the artist's name or MusicBrainz id to
|
||||
Last.fm, and only the MusicBrainz id to MusicBrainz: Sonda never looks an id up by name,
|
||||
so for an artist whose id is not known (it comes from the tags in the music files) the
|
||||
MusicBrainz entry says `no_id`. Show each `attribution` where you show the tags.
|
||||
Last.fm (its id when known), and only the MusicBrainz id to MusicBrainz: Sonda never looks
|
||||
an id up by name. An artist's id comes from the tags in the music files, or from Last.fm
|
||||
for an artist it named that is not in the library; for any other artist the MusicBrainz
|
||||
entry says `no_id`. Show each `attribution` where you show the tags.
|
||||
security: [{bearerAuth: []}]
|
||||
responses:
|
||||
'200':
|
||||
|
|
|
|||
Loading…
Reference in a new issue