diff --git a/web/src/i18n/locales/en.json b/web/src/i18n/locales/en.json index 5030f6e..99b1036 100644 --- a/web/src/i18n/locales/en.json +++ b/web/src/i18n/locales/en.json @@ -59,6 +59,66 @@ "currentPasswordWrong": "The current password is wrong.", "changePassword": "Change password" }, + "admin": { + "title": "Admin", + "sections": "Admin sections", + "adminOnly": "Only admins can see this page.", + "sectionLibraries": "Libraries", + "cancel": "Cancel", + "save": "Save", + "errors": { + "scan_running": "A scan is already running.", + "no_libraries": "Add a library first.", + "admin_required": "Only an admin can do this." + }, + "libraries": { + "title": "Libraries", + "empty": "No libraries yet. Add one below.", + "addTitle": "Add a library", + "name": "Name", + "folder": "Folder on the server", + "folderHint": "The folder must exist on the machine that runs Sonda, not on this computer.", + "add": "Add library", + "scan": "Scan", + "scanOne": "Scan {{name}}", + "edit": "Edit", + "editOne": "Edit {{name}}", + "editTitle": "Edit {{name}}", + "remove": "Remove", + "removeOne": "Remove {{name}}", + "removeTitle": "Remove {{name}}?", + "removeBody": "Sonda stops listing this library. Tracks and listening history stay, and the music on disk is never touched.", + "removeConfirm": "Remove library", + "errors": { + "invalid_input": "The folder must be an existing directory on the server, not the root, and not inside or around another library.", + "library_exists": "Another library already has this name or folder." + } + }, + "scan": { + "title": "Scan", + "all": "Scan all libraries", + "full": "Read every file again", + "fullHint": "Slower. Use it to read tags that earlier scans skipped, such as MusicBrainz ids and genres.", + "running": "A scan is running.", + "never": "No scan has run yet.", + "last": "Last scan", + "finished": "Finished {{when}}", + "unsupported_one": "{{count}} file is in a format Sonda cannot read yet (such as m4a, ogg or wav).", + "unsupported_other": "{{count}} files are in formats Sonda cannot read yet (such as m4a, ogg or wav).", + "counts": { + "found_one": "{{count}} audio file found", + "found_other": "{{count}} audio files found", + "added": "{{count}} added", + "updated": "{{count}} updated", + "unchanged": "{{count}} unchanged", + "renamed": "{{count}} moved", + "restored": "{{count}} back again", + "missing": "{{count}} missing", + "failed": "{{count}} could not be read", + "skipped": "{{count}} skipped (links and special files)" + } + } + }, "lidarr": { "request": "Request on Lidarr", "checkAgain": "Check again", diff --git a/web/src/i18n/locales/it.json b/web/src/i18n/locales/it.json index 3f4904c..0028a6a 100644 --- a/web/src/i18n/locales/it.json +++ b/web/src/i18n/locales/it.json @@ -59,6 +59,66 @@ "currentPasswordWrong": "La password attuale è sbagliata.", "changePassword": "Cambia password" }, + "admin": { + "title": "Admin", + "sections": "Sezioni admin", + "adminOnly": "Solo gli admin possono vedere questa pagina.", + "sectionLibraries": "Librerie", + "cancel": "Annulla", + "save": "Salva", + "errors": { + "scan_running": "Una scansione è già in corso.", + "no_libraries": "Aggiungi prima una libreria.", + "admin_required": "Solo un admin può farlo." + }, + "libraries": { + "title": "Librerie", + "empty": "Ancora nessuna libreria. Aggiungine una qui sotto.", + "addTitle": "Aggiungi una libreria", + "name": "Nome", + "folder": "Cartella sul server", + "folderHint": "La cartella deve esistere sulla macchina che esegue Sonda, non su questo computer.", + "add": "Aggiungi libreria", + "scan": "Scansiona", + "scanOne": "Scansiona {{name}}", + "edit": "Modifica", + "editOne": "Modifica {{name}}", + "editTitle": "Modifica {{name}}", + "remove": "Rimuovi", + "removeOne": "Rimuovi {{name}}", + "removeTitle": "Rimuovere {{name}}?", + "removeBody": "Sonda smette di elencare questa libreria. Brani e cronologia degli ascolti restano, e la musica sul disco non viene mai toccata.", + "removeConfirm": "Rimuovi libreria", + "errors": { + "invalid_input": "La cartella deve essere una directory esistente sul server, non la radice, e non dentro o attorno a un'altra libreria.", + "library_exists": "Un'altra libreria ha già questo nome o questa cartella." + } + }, + "scan": { + "title": "Scansione", + "all": "Scansiona tutte le librerie", + "full": "Rileggi ogni file", + "fullHint": "Più lenta. Serve a leggere i tag che le scansioni precedenti hanno saltato, come gli id MusicBrainz e i generi.", + "running": "Una scansione è in corso.", + "never": "Nessuna scansione eseguita finora.", + "last": "Ultima scansione", + "finished": "Finita il {{when}}", + "unsupported_one": "{{count}} file è in un formato che Sonda non legge ancora (come m4a, ogg o wav).", + "unsupported_other": "{{count}} file sono in formati che Sonda non legge ancora (come m4a, ogg o wav).", + "counts": { + "found_one": "{{count}} file audio trovato", + "found_other": "{{count}} file audio trovati", + "added": "{{count}} aggiunti", + "updated": "{{count}} aggiornati", + "unchanged": "{{count}} invariati", + "renamed": "{{count}} spostati", + "restored": "{{count}} tornati", + "missing": "{{count}} mancanti", + "failed": "{{count}} illeggibili", + "skipped": "{{count}} saltati (collegamenti e file speciali)" + } + } + }, "lidarr": { "request": "Richiedi su Lidarr", "checkAgain": "Controlla di nuovo", diff --git a/web/src/pages/admin/AddLibraryForm.test.tsx b/web/src/pages/admin/AddLibraryForm.test.tsx new file mode 100644 index 0000000..9b63f02 --- /dev/null +++ b/web/src/pages/admin/AddLibraryForm.test.tsx @@ -0,0 +1,81 @@ +import { QueryClient, QueryClientProvider } from '@tanstack/react-query' +import { render, screen, waitFor } from '@testing-library/react' +import userEvent from '@testing-library/user-event' +import { beforeEach, expect, test, vi } from 'vitest' +import { sessionStore } from '@/auth/session' +import { initI18n } from '@/i18n' +import { apiError, mockFetch } from '@/test/mockFetch' +import AddLibraryForm from './AddLibraryForm' + +const created = () => + new Response(JSON.stringify({ id: 9, name: 'Jazz', path: '/srv/jazz', created_at: '2026-11-12T10:00:00Z' }), { + status: 201, + headers: { 'Content-Type': 'application/json' }, + }) + +function renderForm() { + const client = new QueryClient({ defaultOptions: { queries: { retry: false }, mutations: { retry: false } } }) + return render( + + + , + ) +} + +const name = () => screen.getByLabelText('Name') +const folder = () => screen.getByLabelText('Folder on the server') +const add = () => screen.getByRole('button', { name: 'Add library' }) + +beforeEach(async () => { + vi.spyOn(navigator, 'language', 'get').mockReturnValue('en-US') + await initI18n() + sessionStore.setState({ status: 'authenticated', user: { id: 1, username: 'tom', is_admin: true } }) +}) + +test('it says the folder is on the machine that runs Sonda, not on this computer', () => { + mockFetch({}) + renderForm() + expect(screen.getByText(/on the machine that runs Sonda, not on this computer/)).toBeInTheDocument() +}) + +test('nothing is sent while the name or the folder is empty', async () => { + const { calls } = mockFetch({}) + renderForm() + expect(add()).toBeDisabled() + await userEvent.type(name(), 'Jazz') + expect(add()).toBeDisabled() + await userEvent.type(folder(), ' ') + expect(add()).toBeDisabled() + expect(calls).toHaveLength(0) +}) + +test('adding sends the trimmed name and folder, then empties the form', async () => { + const { calls } = mockFetch({ 'POST /api/v1/libraries': created }) + renderForm() + await userEvent.type(name(), ' Jazz ') + await userEvent.type(folder(), ' /srv/jazz ') + await userEvent.click(add()) + await waitFor(() => expect(name()).toHaveValue('')) + expect(folder()).toHaveValue('') + expect(JSON.parse(String(calls[0].init.body))).toEqual({ name: 'Jazz', path: '/srv/jazz' }) +}) + +test.each([ + [400, 'invalid_input', 'The folder must be an existing directory on the server, not the root, and not inside or around another library.'], + [409, 'library_exists', 'Another library already has this name or folder.'], +])('a refusal (%i %s) is explained and what was typed stays', async (status, code, text) => { + mockFetch({ 'POST /api/v1/libraries': () => apiError(status, code) }) + renderForm() + await userEvent.type(name(), 'Jazz') + await userEvent.type(folder(), '/srv/jazz') + await userEvent.click(add()) + expect(await screen.findByRole('alert')).toHaveTextContent(text) + expect(name()).toHaveValue('Jazz') + expect(folder()).toHaveValue('/srv/jazz') +}) + +test('the name is limited to the 100 characters the server accepts', () => { + mockFetch({}) + renderForm() + expect(name()).toHaveAttribute('maxlength', '100') +}) diff --git a/web/src/pages/admin/AddLibraryForm.tsx b/web/src/pages/admin/AddLibraryForm.tsx new file mode 100644 index 0000000..967966b --- /dev/null +++ b/web/src/pages/admin/AddLibraryForm.tsx @@ -0,0 +1,57 @@ +import { useState, type FormEvent } from 'react' +import { useTranslation } from 'react-i18next' +import { useAddLibrary } from '@/api/libraries' +import Section from '@/components/Section' +import { Button } from '@/components/ui/button' +import { Input } from '@/components/ui/input' +import { Label } from '@/components/ui/label' +import { errorText } from './errorText' + +/** What the server accepts as a library name. */ +const MAX_NAME = 100 + +export default function AddLibraryForm() { + const { t } = useTranslation() + const add = useAddLibrary() + const [name, setName] = useState('') + const [path, setPath] = useState('') + const ready = name.trim() !== '' && path.trim() !== '' + + function submit(event: FormEvent) { + event.preventDefault() + if (!ready) return + add.mutate( + { name: name.trim(), path: path.trim() }, + { + onSuccess: () => { + setName('') + setPath('') + }, + }, + ) + } + + return ( +
+
+
+ + setName(e.target.value)} /> +
+
+ + setPath(e.target.value)} autoCapitalize="off" spellCheck={false} /> +

{t('admin.libraries.folderHint')}

+
+ {add.isError && ( +

+ {errorText(t, add.error, ['admin.libraries.errors', 'admin.errors'])} +

+ )} + +
+
+ ) +} diff --git a/web/src/pages/admin/AdminLayout.test.tsx b/web/src/pages/admin/AdminLayout.test.tsx new file mode 100644 index 0000000..abdce8e --- /dev/null +++ b/web/src/pages/admin/AdminLayout.test.tsx @@ -0,0 +1,44 @@ +import { render, screen } from '@testing-library/react' +import { MemoryRouter, Route, Routes } from 'react-router-dom' +import { beforeEach, expect, test, vi } from 'vitest' +import { sessionStore } from '@/auth/session' +import { initI18n } from '@/i18n' +import { mockFetch } from '@/test/mockFetch' +import AdminLayout from './AdminLayout' + +function renderAdmin(path = '/admin/libraries') { + return render( + + + }> + the libraries page

} /> +
+
+
, + ) +} + +beforeEach(async () => { + vi.spyOn(navigator, 'language', 'get').mockReturnValue('en-US') + await initI18n() +}) + +test('an admin gets the admin page with its sections and the page of the section', () => { + sessionStore.setState({ status: 'authenticated', user: { id: 1, username: 'tom', is_admin: true } }) + renderAdmin() + expect(screen.getByRole('heading', { level: 1, name: 'Admin' })).toBeInTheDocument() + expect(screen.getByRole('navigation', { name: 'Admin sections' })).toBeInTheDocument() + expect(screen.getByRole('link', { name: 'Libraries' })).toHaveAttribute('aria-current', 'page') + expect(screen.getByText('the libraries page')).toBeInTheDocument() +}) + +test('anyone else sees a notice, not the section, and nothing is asked of the server', async () => { + sessionStore.setState({ status: 'authenticated', user: { id: 2, username: 'ann', is_admin: false } }) + const { calls } = mockFetch({}) + renderAdmin() + expect(screen.getByText('Only admins can see this page.')).toBeInTheDocument() + expect(screen.queryByText('the libraries page')).not.toBeInTheDocument() + expect(screen.queryByRole('navigation', { name: 'Admin sections' })).not.toBeInTheDocument() + await new Promise((r) => setTimeout(r, 30)) + expect(calls).toHaveLength(0) +}) diff --git a/web/src/pages/admin/AdminLayout.tsx b/web/src/pages/admin/AdminLayout.tsx new file mode 100644 index 0000000..2fea6b1 --- /dev/null +++ b/web/src/pages/admin/AdminLayout.tsx @@ -0,0 +1,41 @@ +import { useTranslation } from 'react-i18next' +import { NavLink, Outlet } from 'react-router-dom' +import { useSession } from '@/auth/session' +import { EmptyMessage } from '@/components/Status' +import { cn } from '@/lib/utils' + +/** The sections of the admin area; each is a route under `/admin`. */ +const SECTIONS = [{ to: '/admin/libraries', key: 'admin.sectionLibraries' }] + +/** + * The frame of the admin area. Only an admin gets the sections: anyone else gets a notice, and since the + * section pages are never rendered for them, nothing is asked of the server (which would say 403 anyway). + */ +export default function AdminLayout() { + const { t } = useTranslation() + const { user } = useSession() + if (!user?.is_admin) return {t('admin.adminOnly')} + + return ( +
+

{t('admin.title')}

+ + +
+ ) +} diff --git a/web/src/pages/admin/LibraryList.test.tsx b/web/src/pages/admin/LibraryList.test.tsx new file mode 100644 index 0000000..0a9dd8a --- /dev/null +++ b/web/src/pages/admin/LibraryList.test.tsx @@ -0,0 +1,174 @@ +import { QueryClient, QueryClientProvider } from '@tanstack/react-query' +import { render, screen, waitFor, within } from '@testing-library/react' +import userEvent from '@testing-library/user-event' +import { beforeEach, expect, test, vi } from 'vitest' +import { sessionStore } from '@/auth/session' +import { initI18n } from '@/i18n' +import { apiError, mockFetch, type MockRoutes, type RecordedCall } from '@/test/mockFetch' +import LibraryList from './LibraryList' + +const lib = (id: number, name: string, path: string) => ({ id, name, path, created_at: '2026-11-12T10:00:00Z' }) +const none = () => new Response(null, { status: 204 }) +const started = () => new Response(JSON.stringify({ status: 'started' }), { status: 202, headers: { 'Content-Type': 'application/json' } }) + +function renderList(full = false) { + const client = new QueryClient({ defaultOptions: { queries: { retry: false }, mutations: { retry: false } } }) + return render( + + + , + ) +} + +function routes(over: MockRoutes = {}): MockRoutes { + return { + 'GET /api/v1/libraries': () => ({ libraries: [lib(1, 'Music', '/srv/music'), lib(2, 'Jazz', '/srv/jazz')] }), + 'GET /api/v1/library/scan': () => ({ running: false }), + ...over, + } +} + +const row = async (name: string) => (await screen.findByText(name)).closest('li') as HTMLElement +const bodies = (calls: RecordedCall[], key: string) => calls.filter((c) => c.key === key).map((c) => JSON.parse(String(c.init.body))) + +beforeEach(async () => { + vi.spyOn(navigator, 'language', 'get').mockReturnValue('en-US') + await initI18n() + sessionStore.setState({ status: 'authenticated', user: { id: 1, username: 'tom', is_admin: true } }) +}) + +test('each library shows its name and its folder on the server', async () => { + mockFetch(routes()) + renderList() + const music = await row('Music') + expect(music).toHaveTextContent('/srv/music') + expect(await row('Jazz')).toHaveTextContent('/srv/jazz') +}) + +test('with no library it says how to start', async () => { + mockFetch(routes({ 'GET /api/v1/libraries': () => ({ libraries: [] }) })) + renderList() + expect(await screen.findByText('No libraries yet. Add one below.')).toBeInTheDocument() +}) + +test('a failure to read the list is said in words with a way to try again', async () => { + mockFetch(routes({ 'GET /api/v1/libraries': () => apiError(500, 'internal') })) + renderList() + const alert = await screen.findByRole('alert') + expect(within(alert).getByRole('button', { name: 'Try again' })).toBeInTheDocument() +}) + +test('"Scan" starts a scan of that library only', async () => { + const { calls } = mockFetch(routes({ 'POST /api/v1/libraries/2/scan': started })) + renderList() + await userEvent.click(within(await row('Jazz')).getByRole('button', { name: 'Scan Jazz' })) + const post = calls.find((c) => c.key === 'POST /api/v1/libraries/2/scan') + expect(post).toBeDefined() + expect(post?.url.searchParams.has('full')).toBe(false) +}) + +test('with "read every file again" the scan of a library is a full one', async () => { + const { calls } = mockFetch(routes({ 'POST /api/v1/libraries/1/scan': started })) + renderList(true) + await userEvent.click(within(await row('Music')).getByRole('button', { name: 'Scan Music' })) + expect(calls.find((c) => c.key === 'POST /api/v1/libraries/1/scan')?.url.searchParams.get('full')).toBe('true') +}) + +test('a scan that is already running is explained', async () => { + mockFetch(routes({ 'POST /api/v1/libraries/1/scan': () => apiError(409, 'scan_running') })) + renderList() + await userEvent.click(within(await row('Music')).getByRole('button', { name: 'Scan Music' })) + expect(await screen.findByText('A scan is already running.')).toBeInTheDocument() +}) + +test('while a scan runs no library can be scanned, edited or removed', async () => { + mockFetch(routes({ 'GET /api/v1/library/scan': () => ({ running: true }) })) + renderList() + const music = await row('Music') + await waitFor(() => expect(within(music).getByRole('button', { name: 'Scan Music' })).toBeDisabled()) + expect(within(music).getByRole('button', { name: 'Edit Music' })).toBeDisabled() + expect(within(music).getByRole('button', { name: 'Remove Music' })).toBeDisabled() +}) + +test('removing asks first, and says the music on disk is never touched', async () => { + const { calls } = mockFetch(routes({ 'DELETE /api/v1/libraries/1': none })) + renderList() + await userEvent.click(within(await row('Music')).getByRole('button', { name: 'Remove Music' })) + const dialog = await screen.findByRole('dialog') + expect(dialog).toHaveTextContent('Remove Music?') + expect(dialog).toHaveTextContent('Tracks and listening history stay, and the music on disk is never touched.') + expect(calls.map((c) => c.key)).not.toContain('DELETE /api/v1/libraries/1') + + await userEvent.click(within(dialog).getByRole('button', { name: 'Cancel' })) + await waitFor(() => expect(screen.queryByRole('dialog')).not.toBeInTheDocument()) + expect(calls.map((c) => c.key)).not.toContain('DELETE /api/v1/libraries/1') +}) + +test('confirming removes the library and it leaves the list', async () => { + let libs = [lib(1, 'Music', '/srv/music'), lib(2, 'Jazz', '/srv/jazz')] + mockFetch( + routes({ + 'GET /api/v1/libraries': () => ({ libraries: libs }), + 'DELETE /api/v1/libraries/1': () => { + libs = libs.filter((l) => l.id !== 1) + return none() + }, + }), + ) + renderList() + await userEvent.click(within(await row('Music')).getByRole('button', { name: 'Remove Music' })) + await userEvent.click(within(await screen.findByRole('dialog')).getByRole('button', { name: 'Remove library' })) + await waitFor(() => expect(screen.queryByText('Music')).not.toBeInTheDocument()) + expect(screen.getByText('Jazz')).toBeInTheDocument() +}) + +test('a removal refused because a scan started is explained', async () => { + mockFetch(routes({ 'DELETE /api/v1/libraries/1': () => apiError(409, 'scan_running') })) + renderList() + await userEvent.click(within(await row('Music')).getByRole('button', { name: 'Remove Music' })) + await userEvent.click(within(await screen.findByRole('dialog')).getByRole('button', { name: 'Remove library' })) + expect(await screen.findByText('A scan is already running.')).toBeInTheDocument() +}) + +test('editing starts from what the library has now, and sends only what changed', async () => { + const { calls } = mockFetch(routes({ 'PATCH /api/v1/libraries/1': () => lib(1, 'Main', '/srv/music') })) + renderList() + await userEvent.click(within(await row('Music')).getByRole('button', { name: 'Edit Music' })) + const dialog = await screen.findByRole('dialog') + expect(within(dialog).getByLabelText('Name')).toHaveValue('Music') + expect(within(dialog).getByLabelText('Folder on the server')).toHaveValue('/srv/music') + expect(within(dialog).getByRole('button', { name: 'Save' })).toBeDisabled() + + await userEvent.clear(within(dialog).getByLabelText('Name')) + await userEvent.type(within(dialog).getByLabelText('Name'), 'Main') + await userEvent.click(within(dialog).getByRole('button', { name: 'Save' })) + await waitFor(() => expect(screen.queryByRole('dialog')).not.toBeInTheDocument()) + expect(bodies(calls, 'PATCH /api/v1/libraries/1')).toEqual([{ name: 'Main' }]) +}) + +test('moving a library sends only the folder', async () => { + const { calls } = mockFetch(routes({ 'PATCH /api/v1/libraries/1': () => lib(1, 'Music', '/mnt/music') })) + renderList() + await userEvent.click(within(await row('Music')).getByRole('button', { name: 'Edit Music' })) + const dialog = await screen.findByRole('dialog') + await userEvent.clear(within(dialog).getByLabelText('Folder on the server')) + await userEvent.type(within(dialog).getByLabelText('Folder on the server'), '/mnt/music') + await userEvent.click(within(dialog).getByRole('button', { name: 'Save' })) + await waitFor(() => expect(screen.queryByRole('dialog')).not.toBeInTheDocument()) + expect(bodies(calls, 'PATCH /api/v1/libraries/1')).toEqual([{ path: '/mnt/music' }]) +}) + +test.each([ + [409, 'library_exists', 'Another library already has this name or folder.'], + [409, 'scan_running', 'A scan is already running.'], + [400, 'invalid_input', 'The folder must be an existing directory on the server, not the root, and not inside or around another library.'], +])('an edit refused with %i %s is explained in the dialog, which stays open', async (status, code, text) => { + mockFetch(routes({ 'PATCH /api/v1/libraries/1': () => apiError(status, code) })) + renderList() + await userEvent.click(within(await row('Music')).getByRole('button', { name: 'Edit Music' })) + const dialog = await screen.findByRole('dialog') + await userEvent.type(within(dialog).getByLabelText('Name'), 'x') + await userEvent.click(within(dialog).getByRole('button', { name: 'Save' })) + expect(await within(dialog).findByRole('alert')).toHaveTextContent(text) + expect(screen.getByRole('dialog')).toBeInTheDocument() +}) diff --git a/web/src/pages/admin/LibraryList.tsx b/web/src/pages/admin/LibraryList.tsx new file mode 100644 index 0000000..8de9eb2 --- /dev/null +++ b/web/src/pages/admin/LibraryList.tsx @@ -0,0 +1,156 @@ +import { useState, type FormEvent } from 'react' +import { useTranslation } from 'react-i18next' +import { useLibraries, useRemoveLibrary, useScanStatus, useStartScan, useUpdateLibrary, type Library } from '@/api/libraries' +import Section from '@/components/Section' +import { EmptyMessage, ErrorMessage, Loading } from '@/components/Status' +import { Button } from '@/components/ui/button' +import { Dialog, DialogContent, DialogDescription, DialogFooter, DialogHeader, DialogTitle } from '@/components/ui/dialog' +import { Input } from '@/components/ui/input' +import { Label } from '@/components/ui/label' +import { errorText } from './errorText' + +const SCOPES = ['admin.libraries.errors', 'admin.errors'] +/** What the server accepts as a library name. */ +const MAX_NAME = 100 + +/** Rename and move: the dialog starts from what the library has, and only what changed is sent. */ +function EditDialog({ library, onClose }: { library: Library; onClose: () => void }) { + const { t } = useTranslation() + const update = useUpdateLibrary() + const [name, setName] = useState(library.name) + const [path, setPath] = useState(library.path) + + const changes: { name?: string; path?: string } = {} + if (name.trim() !== library.name) changes.name = name.trim() + if (path.trim() !== library.path) changes.path = path.trim() + const ready = Object.keys(changes).length > 0 && name.trim() !== '' && path.trim() !== '' + + function submit(event: FormEvent) { + event.preventDefault() + if (ready) update.mutate({ id: library.id, ...changes }, { onSuccess: onClose }) + } + + return ( + !open && onClose()}> + +
+ + {t('admin.libraries.editTitle', { name: library.name })} + {t('admin.libraries.folderHint')} + +
+ + setName(e.target.value)} /> +
+
+ + setPath(e.target.value)} autoCapitalize="off" spellCheck={false} /> +
+ {update.isError && ( +

+ {errorText(t, update.error, SCOPES)} +

+ )} + + + + +
+
+
+ ) +} + +function RemoveDialog({ library, onClose, onConfirm }: { library: Library; onClose: () => void; onConfirm: () => void }) { + const { t } = useTranslation() + return ( + !open && onClose()}> + + + {t('admin.libraries.removeTitle', { name: library.name })} + {t('admin.libraries.removeBody')} + + + + + + + + ) +} + +/** The libraries, each with what an admin can do to it. Nothing can be changed or scanned while a scan runs. */ +export default function LibraryList({ full }: { full: boolean }) { + const { t } = useTranslation() + const libraries = useLibraries() + const status = useScanStatus() + const scan = useStartScan() + const remove = useRemoveLibrary() + const [editing, setEditing] = useState(null) + const [removing, setRemoving] = useState(null) + const busy = status.data?.running === true || scan.isPending || remove.isPending + const failure = scan.error ?? remove.error + + return ( +
+ {libraries.isError ? ( + void libraries.refetch()} /> + ) : libraries.isPending ? ( + + ) : libraries.data.length === 0 ? ( + {t('admin.libraries.empty')} + ) : ( +
    + {libraries.data.map((library) => ( +
  • +
    + {library.name} + {library.path} +
    +
    + + + +
    +
  • + ))} +
+ )} + + {failure ? ( +

+ {errorText(t, failure, SCOPES)} +

+ ) : null} + + {editing && setEditing(null)} />} + {removing && ( + setRemoving(null)} + onConfirm={() => { + remove.mutate(removing.id) + setRemoving(null) + }} + /> + )} +
+ ) +} diff --git a/web/src/pages/admin/ScanPanel.test.tsx b/web/src/pages/admin/ScanPanel.test.tsx new file mode 100644 index 0000000..2de25c5 --- /dev/null +++ b/web/src/pages/admin/ScanPanel.test.tsx @@ -0,0 +1,122 @@ +import { QueryClient, QueryClientProvider } from '@tanstack/react-query' +import { render, screen } from '@testing-library/react' +import userEvent from '@testing-library/user-event' +import { useState } from 'react' +import { beforeEach, expect, test, vi } from 'vitest' +import { sessionStore } from '@/auth/session' +import { initI18n } from '@/i18n' +import { apiError, mockFetch, type MockRoutes, type RecordedCall } from '@/test/mockFetch' +import ScanPanel from './ScanPanel' + +const started = () => new Response(JSON.stringify({ status: 'started' }), { status: 202, headers: { 'Content-Type': 'application/json' } }) + +const summary = (over: object = {}) => ({ + libraries: 2, + found: 120, + added: 10, + updated: 3, + unchanged: 100, + renamed: 1, + restored: 0, + missing: 2, + failed: 1, + skipped: 0, + unsupported: 7, + ...over, +}) + +function Harness() { + const [full, setFull] = useState(false) + return +} + +function renderPanel() { + const client = new QueryClient({ defaultOptions: { queries: { retry: false }, mutations: { retry: false } } }) + return render( + + + , + ) +} + +function routes(status: object, over: MockRoutes = {}): MockRoutes { + return { 'GET /api/v1/library/scan': () => status, ...over } +} + +const posts = (calls: RecordedCall[]) => calls.filter((c) => c.key === 'POST /api/v1/library/scan') + +beforeEach(async () => { + vi.spyOn(navigator, 'language', 'get').mockReturnValue('en-US') + await initI18n() + sessionStore.setState({ status: 'authenticated', user: { id: 1, username: 'tom', is_admin: true } }) +}) + +test('after a scan it shows how it went, and the files Sonda cannot read yet stand out', async () => { + mockFetch(routes({ running: false, last_finished_at: '2026-11-12T10:00:00Z', last: summary() })) + renderPanel() + const list = await screen.findByRole('list', { name: 'Last scan' }) + expect(list).toHaveTextContent('120 audio files found') + expect(list).toHaveTextContent('10 added') + expect(list).toHaveTextContent('2 missing') + expect(list).toHaveTextContent('1 could not be read') + expect(screen.getByText('7 files are in formats Sonda cannot read yet (such as m4a, ogg or wav).')).toBeInTheDocument() +}) + +test('with nothing unsupported it does not mention formats', async () => { + mockFetch(routes({ running: false, last_finished_at: '2026-11-12T10:00:00Z', last: summary({ unsupported: 0 }) })) + renderPanel() + await screen.findByRole('list', { name: 'Last scan' }) + expect(screen.queryByText(/cannot read yet/)).not.toBeInTheDocument() +}) + +test('before any scan it says so', async () => { + mockFetch(routes({ running: false })) + renderPanel() + expect(await screen.findByText('No scan has run yet.')).toBeInTheDocument() +}) + +test('a scan that ended in an error shows the reason', async () => { + mockFetch(routes({ running: false, last_error: 'library "Music" is empty or unreadable' })) + renderPanel() + expect(await screen.findByRole('alert')).toHaveTextContent('library "Music" is empty or unreadable') +}) + +test('"Scan all" starts a scan of everything, reading only what changed', async () => { + const { calls } = mockFetch(routes({ running: false }, { 'POST /api/v1/library/scan': started })) + renderPanel() + await userEvent.click(await screen.findByRole('button', { name: 'Scan all libraries' })) + expect(posts(calls)).toHaveLength(1) + expect(posts(calls)[0].url.searchParams.has('full')).toBe(false) +}) + +test('"Read every file again" makes the scan a full one', async () => { + const { calls } = mockFetch(routes({ running: false }, { 'POST /api/v1/library/scan': started })) + renderPanel() + await userEvent.click(await screen.findByRole('checkbox', { name: 'Read every file again' })) + await userEvent.click(screen.getByRole('button', { name: 'Scan all libraries' })) + expect(posts(calls)[0].url.searchParams.get('full')).toBe('true') +}) + +test('while a scan runs the button waits and the page says so', async () => { + mockFetch(routes({ running: true, started_at: '2026-11-12T10:00:00Z' })) + renderPanel() + expect(await screen.findByText('A scan is running.')).toBeInTheDocument() + expect(screen.getByRole('button', { name: 'Scan all libraries' })).toBeDisabled() +}) + +test.each([ + ['scan_running', 'A scan is already running.'], + ['no_libraries', 'Add a library first.'], +])('a refusal (%s) is explained', async (code, text) => { + mockFetch(routes({ running: false }, { 'POST /api/v1/library/scan': () => apiError(409, code) })) + renderPanel() + await userEvent.click(await screen.findByRole('button', { name: 'Scan all libraries' })) + expect(await screen.findByText(text)).toBeInTheDocument() +}) + +test('an unexpected failure to start is said in words', async () => { + mockFetch(routes({ running: false }, { 'POST /api/v1/library/scan': () => apiError(500, 'internal') })) + renderPanel() + await userEvent.click(await screen.findByRole('button', { name: 'Scan all libraries' })) + expect(await screen.findByText('Something went wrong. Try again.')).toBeInTheDocument() +}) diff --git a/web/src/pages/admin/ScanPanel.tsx b/web/src/pages/admin/ScanPanel.tsx new file mode 100644 index 0000000..1989d50 --- /dev/null +++ b/web/src/pages/admin/ScanPanel.tsx @@ -0,0 +1,91 @@ +import { useTranslation } from 'react-i18next' +import { useScanStatus, useStartScan, type ScanSummary } from '@/api/libraries' +import Section from '@/components/Section' +import { EmptyMessage, ErrorMessage, Loading } from '@/components/Status' +import { Button } from '@/components/ui/button' +import { errorText } from './errorText' + +/** The counts of a scan, leaving out what is zero (except what was found). */ +function Summary({ summary, finishedAt }: { summary: ScanSummary; finishedAt?: string }) { + const { t, i18n } = useTranslation() + const rows: [string, number][] = [ + ['found', summary.found], + ['added', summary.added], + ['updated', summary.updated], + ['unchanged', summary.unchanged], + ['renamed', summary.renamed], + ['restored', summary.restored], + ['missing', summary.missing], + ['failed', summary.failed], + ['skipped', summary.skipped], + ] + return ( +
+
    + {rows + .filter(([key, count]) => key === 'found' || count > 0) + .map(([key, count]) => ( +
  • + {t(`admin.scan.counts.${key}`, { count })} +
  • + ))} +
+ {summary.unsupported > 0 && ( +

{t('admin.scan.unsupported', { count: summary.unsupported })}

+ )} + {finishedAt && ( +

+ {t('admin.scan.finished', { when: new Date(finishedAt).toLocaleString(i18n.language) })} +

+ )} +
+ ) +} + +/** Scan everything, and how the last scan went. The status follows the scan by itself while one runs. */ +export default function ScanPanel({ full, onFullChange }: { full: boolean; onFullChange: (full: boolean) => void }) { + const { t } = useTranslation() + const status = useScanStatus() + const start = useStartScan() + const running = status.data?.running === true + + return ( +
+
+ +

{t('admin.scan.fullHint')}

+ + {start.isError && ( +

+ {errorText(t, start.error)} +

+ )} +
+ + {status.isError ? ( + void status.refetch()} /> + ) : status.isPending ? ( + + ) : running ? ( +

+ {t('admin.scan.running')} +

+ ) : ( + <> + {status.data.last && } + {status.data.last_error && ( +

+ {status.data.last_error} +

+ )} + {!status.data.last && !status.data.last_error && {t('admin.scan.never')}} + + )} +
+ ) +} diff --git a/web/src/pages/admin/errorText.ts b/web/src/pages/admin/errorText.ts new file mode 100644 index 0000000..c616c57 --- /dev/null +++ b/web/src/pages/admin/errorText.ts @@ -0,0 +1,16 @@ +import type { TFunction } from 'i18next' +import { ApiError } from '@/api/client' +import { errorMessageKey, i18n } from '@/i18n' + +/** + * An API error in words. The first scope that has a text for its code wins, so a section can say its own + * thing for a code (a bad folder) and leave the rest to the shared texts; then the generic ones. + */ +export function errorText(t: TFunction, error: unknown, scopes: string[] = ['admin.errors']): string { + const code = error instanceof ApiError ? error.code : 'unknown' + for (const scope of scopes) { + const key = `${scope}.${code}` + if (i18n.exists(key)) return t(key) + } + return t(errorMessageKey(code)) +}