From 80a26aeb4af4c62d7a959cfa5d3521f67de5e280 Mon Sep 17 00:00:00 2001 From: tgiachi Date: Thu, 12 Nov 2026 11:58:48 +0100 Subject: [PATCH] fix(web): keep the player bar on screen, label the settings choices, compact menu on phones - the player bar stays at the bottom on long pages (sticky sits on its wrapper, not on the bar) - theme and language groups in Settings have a visible label - on a phone the menu is a row of links instead of a tall card, and the privacy note is left out there - the full-screen player is centred vertically Found by running the app in a real browser against a real server. --- web/src/components/ChoiceGroup.tsx | 42 ++++++++++++++---------- web/src/components/layout/NowPlaying.tsx | 2 +- web/src/components/layout/PlayerBar.tsx | 2 +- web/src/components/layout/Shell.tsx | 3 +- web/src/components/layout/Sidebar.tsx | 11 +++++-- web/src/pages/SettingsPage.test.tsx | 8 +++++ 6 files changed, 44 insertions(+), 24 deletions(-) diff --git a/web/src/components/ChoiceGroup.tsx b/web/src/components/ChoiceGroup.tsx index 677cf8d..14b836c 100644 --- a/web/src/components/ChoiceGroup.tsx +++ b/web/src/components/ChoiceGroup.tsx @@ -17,25 +17,31 @@ interface ChoiceGroupProps { /** One choice out of a few, as native radio buttons: the arrow keys and screen readers work as they should. */ export default function ChoiceGroup({ label, choices, value, onChange }: ChoiceGroupProps) { const name = useId() + const labelId = `${name}-label` return ( -
- {choices.map((choice) => ( - - ))} +
+

+ {label} +

+
+ {choices.map((choice) => ( + + ))} +
) } diff --git a/web/src/components/layout/NowPlaying.tsx b/web/src/components/layout/NowPlaying.tsx index a9008d3..f925765 100644 --- a/web/src/components/layout/NowPlaying.tsx +++ b/web/src/components/layout/NowPlaying.tsx @@ -32,7 +32,7 @@ export default function NowPlaying() { {track && ( <> diff --git a/web/src/components/layout/PlayerBar.tsx b/web/src/components/layout/PlayerBar.tsx index 91ea5a3..e28c493 100644 --- a/web/src/components/layout/PlayerBar.tsx +++ b/web/src/components/layout/PlayerBar.tsx @@ -37,7 +37,7 @@ export default function PlayerBar() { return (