- fix: errors from the outbound client no longer carry the query string. Go puts
the whole URL into a transport error, and a Last.fm key travels in the query,
so any log of such an error would have written the key. The host and path stay
for debugging and the cause can still be matched with errors.Is
- fix: a request that gives up while waiting for its turn gives the turn back,
and a turn is not taken at all when the wait would pass the caller's deadline.
Before, a burst of impatient callers pushed the queue further away until no
request ever reached the provider
- fix: failures of requests that were already in flight when the provider died
no longer double the breaker window each; one outage opens it once
- fix: redirects and oversized answers count as failures, so a provider that
keeps answering that way stops being asked
- fix: sending an empty api_key to a provider that needs none (MusicBrainz) no
longer turns it off
- test: the query string in transport errors, refused connections and timeouts;
cancelling during the wait; the deadline shorter than the wait; twelve
concurrent failures; redirects and big answers; the empty key. Checked by
removing each fix on purpose