Close the minor findings of the first review #7

Merged
squid merged 2 commits from fix/review-minors into main 2026-11-15 09:40:06 +00:00
Owner

I'm closing the minor findings of the first review of the generator (#2).

  • Require refuses an empty value; heading ids are checked (an explicit {#id} must be sound and unique, generated ids avoid explicit ones and each other, a heading with no ASCII letters gets a fallback).
  • Fenced code blocks keep their placeholders, found the way CommonMark finds them (lists and quotes too). A backslash before a placeholder keeps it as written, in a code span and next to a block name too.
  • The em dash rule reports the line of the body, refuses padded entities and checks the header keys of the manifesto pages.
  • The feed makes src links absolute and leaves protocol-relative ones alone; base_url is required, needs a host and cannot be set by a language file; the news page must be a folder index.
  • A category written twice in a post counts once, a block name in a news title is no longer taken for a placeholder, and motorino build refuses extra arguments.

The real site builds to the same HTML as before, and a second review of this branch found one critical and two important problems in my first version of the code-block scanner, all fixed here with tests.

Closes #2

I'm closing the minor findings of the first review of the generator (#2). - `Require` refuses an empty value; heading ids are checked (an explicit `{#id}` must be sound and unique, generated ids avoid explicit ones and each other, a heading with no ASCII letters gets a fallback). - Fenced code blocks keep their placeholders, found the way CommonMark finds them (lists and quotes too). A backslash before a placeholder keeps it as written, in a code span and next to a block name too. - The em dash rule reports the line of the body, refuses padded entities and checks the header keys of the manifesto pages. - The feed makes `src` links absolute and leaves protocol-relative ones alone; `base_url` is required, needs a host and cannot be set by a language file; the news page must be a folder index. - A category written twice in a post counts once, a block name in a news title is no longer taken for a placeholder, and `motorino build` refuses extra arguments. The real site builds to the same HTML as before, and a second review of this branch found one critical and two important problems in my first version of the code-block scanner, all fixed here with tests. Closes #2
Require refuses an empty value. Heading ids: an explicit {#id} must be sound
and unique, generated ids avoid the explicit ones and each other, and a heading
with no ASCII letters gets a fallback. Fenced code blocks keep their
placeholders and a backslash keeps one anywhere. The em dash rule covers the
header of the manifesto pages and the HTML entities. The feed makes src links
absolute, base_url is required, and the news page must be a folder index. A
category written twice in a post counts once, a block name in a news title is no
longer taken for a placeholder, and build refuses extra arguments.
fix: find code blocks with the Markdown parser and make the escape work everywhere
All checks were successful
check / check (pull_request) Successful in 30s
4ab8f8d122
The hand written fence scanner took a line that starts with a code span for a
fence and missed fences in quotes and lists. The code blocks are now the ones
goldmark finds. A backslash before a placeholder is turned into a marker that
survives the Markdown and the list expansion, so it works in a code span and
next to a block name, and two backslashes are a literal one. The em dash rule
reports the line of the body, refuses padded entities and checks the header keys
by name, the feed leaves protocol-relative links alone, base_url needs a host
and a language file cannot set it.
squid merged commit 3411f2c522 into main 2026-11-15 09:40:06 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
squid/motorino!7
No description provided.