Close the minor findings of the first review #7
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/review-minors"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I'm closing the minor findings of the first review of the generator (#2).
Requirerefuses an empty value; heading ids are checked (an explicit{#id}must be sound and unique, generated ids avoid explicit ones and each other, a heading with no ASCII letters gets a fallback).srclinks absolute and leaves protocol-relative ones alone;base_urlis required, needs a host and cannot be set by a language file; the news page must be a folder index.motorino buildrefuses extra arguments.The real site builds to the same HTML as before, and a second review of this branch found one critical and two important problems in my first version of the code-block scanner, all fixed here with tests.
Closes #2
Require refuses an empty value. Heading ids: an explicit {#id} must be sound and unique, generated ids avoid the explicit ones and each other, and a heading with no ASCII letters gets a fallback. Fenced code blocks keep their placeholders and a backslash keeps one anywhere. The em dash rule covers the header of the manifesto pages and the HTML entities. The feed makes src links absolute, base_url is required, and the news page must be a folder index. A category written twice in a post counts once, a block name in a news title is no longer taken for a placeholder, and build refuses extra arguments.